@adoxa Thanks! I don’t suppose you have this set up running in the other direction too? (UTF -> XML) We’ve got a local script that converts things in the other direction for upload, but I’ve found for quite a few of the folks working on the mod, UTFXML simply won’t run properly when invoked via a script, and I think it’s a similar set of dependency issues.
administrators
Full site administrators
Posts
-
-
I have refactored the V2 page to hopefully be a bit more usable. Please let me know if you encounter bugs or have any feedback about the new design.
-
The eventual fix for this, courtesy of @BC46 and @Aingar turned out to be a bit more complicated. Posting it here for visibility:
struct SrvGun { void* vtable; CELauncher* launcher; }; DWORD server; UINT projectilesPerFire; typedef bool (__fastcall HandlePlayerLauncherFire)(SrvGun *srvGun, PVOID _edx, Vector *vector); bool __fastcall HandlePlayerLauncherFire_Hook(SrvGun *srvGun, PVOID _edx, Vector *vector) { projectilesPerFire = srvGun->launcher->GetProjectilesPerFire(); return ((HandlePlayerLauncherFire*) (server + 0xD840))(srvGun, _edx, vector); } __declspec(naked) void SetProjectilesPerFire() { __asm { push 0x3F800000 push [projectilesPerFire] mov eax, [server] add eax, 0xD91A jmp eax } }
server = (DWORD) GetModuleHandleA("server.dll"); Hook(server + 0xD9A9, (DWORD) HandlePlayerLauncherFire_Hook, 5); Hook(server + 0xDC09, (DWORD) HandlePlayerLauncherFire_Hook, 5); Hook(server + 0xE009, (DWORD) HandlePlayerLauncherFire_Hook, 5); Hook(server + 0xD913, (DWORD) SetProjectilesPerFire, 5, true);
This also fixes some serverside issues with ammo counts saving incorrectly on client reconnect,
-
@Gold_Sear No worries! You need to escape the \ character in .json when it’s enclosed in quotes, otherwise it’s not read correctly! Tweaked your PR slightly here with an example: https://github.com/TheStarport/KnowledgeBase/commit/acfd904b0a79d26cdb5b72824703eca00b645ed1
-
@Gold_Sear Apologies, I’ve been away for a week, your PR is now merged in!
I want to do a pass on the tags, I’ll take a look at this and do a cleanup on them.
It’s possible that the build for the page failed which is why it’s out of sync? I’ll take a look at that as wellEDIT: Looks like there was some invalid json, which caused the page generation to fail. I’ve updated this and the page should sync again in about 20 minutes time. -
I’ve run up against a vanilla bug with weapons that have multiple HPFire hardpoints: They don’t properly decrement ammo as you’d expect!
The ammo goes down properly in the weapons window tracker in the bottom right, for instance a weapon with 2 HpFires will lower its ammo count by 2 every time you fire. However if you check your ship’s actual cargo or if you try to buy ammunition from a dock after, you’ll notice that the ammo only seems to be going down by 1 each time, no matter how many projectiles are being fired simultaneously each time.
Has anyone formulated a fix for this? The behaviour seems to be consistent between MP and SP, suggesting this is something in server.dll not firing quite right. @Laz and @Aingar have already taken a peek at this and unfortunately haven’t managed to get anywhere with it. Hoping that perhaps @adoxa or @BC46 might have some insight here that we’ve missed?
-
@Gold_Sear Brill! I’ll cross it off the list. As we’re using unix timestamps here, it’s not a problem at all, we just need to adjust what the script that creates the page displays. If we change our mind in the future we can simply adjust the script and display the down-to-the-minute times again
-
@Gold_Sear Excellent work! I’m going to look at making sure Missions are done tonight.
We’re going to make an update to the page generation script for these. I’ve scoped a little issue to keep track of what needs doing. If there’s anything in addition to what’s in the comment here, please let me know and I’ll do what I can to get it added: https://github.com/TheStarport/KnowledgeBase/issues/39
-
I’ve powered through and completed the HUD section on the new limit breaking in it’s entirety, may get another chunk done this afternoon. I think I may also do a pass of this thread again and ensure any new offsets are added to the new page if they’re not already present.
Freelancer XML Project in Github Workflows
Dev's Limit Breaking 101 Techniques
Vanilla Bug with Multiple Fire Hardpoint Weapons
Dev's Limit Breaking 101 Techniques
Vanilla Bug with Multiple Fire Hardpoint Weapons
Dev's Limit Breaking 101 Techniques
Vanilla Bug with Multiple Fire Hardpoint Weapons
Dev's Limit Breaking 101 Techniques
Dev's Limit Breaking 101 Techniques
Dev's Limit Breaking 101 Techniques